Skip to content

Queue theme language server checks without dropping triggers - #1397

Open
efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/theme-tools-serialize-debounce-1385
Open

efegokdemir wants to merge 1 commit into
Shopify:mainfrom
efegokdemir:efe/theme-tools-serialize-debounce-1385

Conversation

@efegokdemir

Copy link
Copy Markdown

What are you adding in this PR?

Fixes #1385. runChecks now coalesces trigger URIs from calls made during the debounce window. Checks run one at a time, and triggers received during a check are queued for a follow-up run. Regression tests cover merging ordinary and forced calls and serial execution of asynchronous callbacks. All 610 package tests passed (one skipped); the package build and type-check passed.

What's next? Any followup issues?

None.

Tophatting

The change has no visible UI. Automated tests cover the forced and in-flight queue behaviour.

  • I added screenshots of the changes (before and after the changes if applicable)

Before you deploy

  • I included a patch bump changeset

@efegokdemir
efegokdemir requested a review from a team as a code owner November 12, 2026 23:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

theme-language-server: checks get dropped while a forced runChecks is pending

1 participant